Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwanted "empty-library" appearance #1317

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

GuillaumeGomez
Copy link
Member

Fixes #1313.

cc @Nemo157 @jyn514

We will need to remove the files into the existing dirs too I guess?

@Nemo157
Copy link
Member

Nemo157 commented Mar 12, 2021

Looking back into #1300 more, what I don't understand is why it is trying to load a global crates.js instead of a local one for each crate: https://docs.rs/crates-20210304-1.52.0-nightly-45b3c2851.js does not exist but https://docs.rs/syn/1.0.61/crates-20210304-1.52.0-nightly-45b3c2851.js does. Are we incorrectly rewriting this url? (note that search-index.js is loaded locally from the current version)

@GuillaumeGomez
Copy link
Member Author

@Nemo157 This fix works too. Now the problem is that the crates.js path is invalid. I don't how we generate it correctly for search-index.js and source-files.js. Any idea maybe?

@Nemo157
Copy link
Member

Nemo157 commented Mar 13, 2021

This can be merged once rust-lang/rust#83094 is in a nightly, that on its own should fix the issue, this should just avoid copying a file that shouldn't actually be part of the essential files (merging it before that would cause the errors from #1300 again, the symptom in #1313 is less bad).

@jyn514 jyn514 merged commit ac0c45e into rust-lang:master Mar 16, 2021
@GuillaumeGomez GuillaumeGomez deleted the empty-library branch March 16, 2021 18:27
@jyn514
Copy link
Member

jyn514 commented Mar 20, 2021

This can be merged once rust-lang/rust#83094 is in a nightly, that on its own should fix the issue, this should just avoid copying a file that shouldn't actually be part of the essential files (merging it before that would cause the errors from #1300 again, the symptom in #1313 is less bad).

@Nemo157 https://docs.rs/crc8-rs/1.1.0/crc8_rs/ was built with rustc 1.52.0-nightly (36f1f04f1 2021-03-17), but it still shows empty-library and loads crates.js from the suffix path. That makes me worry that deploying this will break all builds again.

@jyn514
Copy link
Member

jyn514 commented Mar 20, 2021

Hmm, it does seem to work locally though.

@GuillaumeGomez
Copy link
Member Author

I think a file needs to be removed somewhere on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs.rs reuses crate-specific resources from empty_library for other crates
3 participants