Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove database_file_handler; give precendence to router error messages #1326

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Remove database_file_handler; give precendence to router error messages #1326

merged 4 commits into from
Mar 22, 2021

Commits on Mar 21, 2021

  1. Give precedence to local shared files over global ones 

    When serving 'essential files', we can either serve the global one,
created when building `empty_library`, or the local one, created when
building the local crate. Currently we default to the global one, but
this causes issues when the file should never have been global in the
first place (such as recently for `crates.js`: see
rust-lang#1313).

This gives precedence to the local file so that the bug will be fixed
when rustdoc fixes it, even if we forget to update
`ESSENTIAL_FILES_UNVERSIONED`.
    @jyn514
    jyn514 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    214710f View commit details
    Browse the repository at this point in the history

  2. Remove database_file_handler; give precendence to router error mess… 

    …ages

The database handler was unused; the router already serves the favicon and it
doesn't do anything else. Note that 'database handler' is different
from 'files served from storage', the router already handles those.

This also fixes the long standing bug that all 404 errors are either
'crate not found' or 'resource not found'.
    @jyn514
    jyn514 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    228ee9f View commit details
    Browse the repository at this point in the history

  3. Remove dead code and make some functions private

    @jyn514
    jyn514 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    ea6e643 View commit details
    Browse the repository at this point in the history

  4. Fix broken metrics test

    @jyn514
    jyn514 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    8010082 View commit details
    Browse the repository at this point in the history