Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add priority and all.html to sitemap #1781

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Jul 24, 2022

related to #1438 and a comment by @jsha

link to the crate root and all.html from the sitemap.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jul 24, 2022
@syphar
Copy link
Member Author

syphar commented Jul 24, 2022

@jsha is this what you meant? :)

If this might help we can give it a try, or leave it when you want to wait and watch the metrics first.

@syphar syphar added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Jul 24, 2022
@jsha
Copy link
Contributor

jsha commented Jul 24, 2022

Yep, this is what I meant; though I hadn't thought of using the <priority> tag. Neat!

Let's give this a couple of weeks after #1773 is deployed. I think this will improve comprehensiveness of crawling, but I don't think it will make that much difference to discovered canonical URLs, and it might make Google take a little longer to recrawl all the things that need recrawling, if those URLs are competing with new URLs from this change.

@jsha
Copy link
Contributor

jsha commented Sep 16, 2022

This seems like a good time to merge this.

@jyn514 jyn514 merged commit cead212 into rust-lang:master Sep 17, 2022
@jyn514 jyn514 deleted the all-html-sitemap branch September 17, 2022 04:08
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 17, 2022
@syphar syphar removed S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. labels Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants