Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dotenv dependency #1815

Merged
merged 3 commits into from
Sep 2, 2022
Merged

remove dotenv dependency #1815

merged 3 commits into from
Sep 2, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Aug 31, 2022

resolves #1811

We need to add the config to the tests explicitly, which personally I like more than how it was done before.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Aug 31, 2022
@syphar
Copy link
Member Author

syphar commented Aug 31, 2022

r? @Nemo157

also @jyn514 (?) to know if this is really not used in prod?

@Nemo157
Copy link
Member

Nemo157 commented Aug 31, 2022

In production the systemd unit is configured with:

EnvironmentFile=/home/cratesfyi/.docs-rs-env
WorkingDirectory=/home/ubuntu/docs.rs

The .env loading is relative to working directory (and walks up the directory tree), so checking for that:

> ls /home/ubuntu/docs.rs/.env /home/ubuntu/.env /home/.env /.env
ls: cannot access '/home/ubuntu/docs.rs/.env': No such file or directory
ls: cannot access '/home/ubuntu/.env': No such file or directory
ls: cannot access '/home/.env': No such file or directory
ls: cannot access '/.env': No such file or directory

@syphar
Copy link
Member Author

syphar commented Aug 31, 2022

@Nemo157 thanks for checking! that sounds like we're safe removing this :)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine, I guess. I'm probably going to be a bit annoyed by it next time I run docs.rs locally, but I also do that so infrequently I don't think my opinion should matter very much.

README.md Outdated Show resolved Hide resolved
@syphar syphar merged commit 07f7edc into rust-lang:master Sep 2, 2022
@syphar syphar deleted the remove-dotenv branch September 2, 2022 05:10
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 2, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0141: dotenv is Unmaintained
3 participants