- 
                Notifications
    You must be signed in to change notification settings 
- Fork 216
Start axum migration #1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Start axum migration #1903
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    929a74b    to
    efab7d8      
    Compare
  
    | cc @rust-lang/docs-rs for review, tests, inpout | 
              
                    jyn514
  
              
              approved these changes
              
                  
                    Nov 12, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great :) I left a bunch of comments but nothing looks blocking.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This starts the migration from iron to axum (see #1900 )
We're using a strangler-fig pattern, so we're running the old iron server in the background, which will be called when we don't find a route in axum. The service is based on adapted code from
axum-strangler.I migrated some handlers from
web::sitemapand some static redirects, especially to show how I thing we should do:ctry,cexpector.unwrap/.expectespecially the combination of template rendering and CSP took some thinking, but IMO this is a good approach.
There is some duplication (
impl_webpage+impl_axum_webpage,AxumNope+Nope,AxumErrorPage+ErrorPage), which was easier to do than figuring out how to design for both Iron & Axum in these structs. And since at some point Iron will be gone, we're fine IMO.I tried to do most of the change in our
TestFrontendso the tests just run as they are, so we're sure everything is fine.other things that will come / are good to know
( see also master...syphar:docs.rs:new-web-axum )
web::routes-> aget_rustdocwill also inject a prefix-blocking middlewarepending manual test
redirect_base)which specifics are not covered with tests good enough?