Skip to content

migrate crate-details handler to axum #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 1, 2022
Merged

migrate crate-details handler to axum #1925

merged 5 commits into from
Dec 1, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Nov 23, 2022

No description provided.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 23, 2022
syphar
syphar commented Nov 23, 2022
View reviewed changes
Nemo157
Nemo157 reviewed Nov 23, 2022
View reviewed changes
@syphar syphar marked this pull request as draft November 23, 2022 15:59
@syphar
Copy link
Member Author

syphar commented Nov 23, 2022

setting back to draft, there are some other test failures that I need to fix first

@syphar syphar force-pushed the axum-crate-details branch from 8502484 to 48f0f68 Compare November 23, 2022 16:47
@syphar syphar force-pushed the axum-crate-details branch from 48f0f68 to ef6dd16 Compare November 23, 2022 16:51
@syphar syphar marked this pull request as ready for review November 23, 2022 16:52
@syphar
Copy link
Member Author

syphar commented Nov 23, 2022

tests should pass now (they did locally), ready for another review

@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 24, 2022
@syphar syphar force-pushed the axum-crate-details branch from f1c2f42 to 09e3680 Compare November 24, 2022 16:22
@syphar syphar force-pushed the axum-crate-details branch from 09e3680 to e911ec5 Compare November 24, 2022 16:34
syphar
syphar commented Nov 24, 2022
View reviewed changes
@syphar syphar added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Nov 24, 2022
@syphar syphar requested a review from Nemo157 November 24, 2022 16:39
@syphar
Copy link
Member Author

syphar commented Nov 24, 2022

@Nemo157 this is ready for another review

@syphar syphar force-pushed the axum-crate-details branch from 1269652 to 9bb9a97 Compare November 25, 2022 06:48
jsha
jsha reviewed Nov 25, 2022
View reviewed changes
@syphar syphar mentioned this pull request Nov 25, 2022
Merged
Nemo157
Nemo157 reviewed Nov 29, 2022
View reviewed changes
@syphar syphar requested a review from Nemo157 November 30, 2022 07:57
@syphar syphar merged commit 4f43557 into rust-lang:master Dec 1, 2022
@syphar syphar deleted the axum-crate-details branch December 1, 2022 17:14
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 1, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha left review comments

@Nemo157 Nemo157 Nemo157 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syphar @Nemo157 @jsha