Skip to content

remove oldtime feature from chrono dependency #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Dec 22, 2022

I checked why after #1963 we still have a dependency to time@0.1.

Chrono actually tried to stay backwards-compatible and introduced an oldtime feature, which is default.

Removing it also removes the depdency to the old time crate.

Checking the other dependencies:

$ cargo tree -i time@0.1.45
time v0.1.45
├── chrono v0.4.23
│   ├── aws-smithy-types-convert v0.51.0
│   │   └── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
│   ├── chrono-tz v0.6.3
│   │   └── tera v1.17.1
│   │       └── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
│   ├── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
│   ├── postgres-types v0.2.4
│   │   ├── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
│   │   └── tokio-postgres v0.7.7
│   │       └── postgres v0.19.4
│   │           ├── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
│   │           ├── r2d2_postgres v0.18.1
│   │           │   └── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
│   │           └── schemamama_postgres v0.3.0
│   │               └── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
│   └── tera v1.17.1 (*)
├── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
└── hyper v0.10.16
    └── iron v0.6.1
        ├── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)
        └── router v0.6.0
            └── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)

They all changed to dropping the oldtime feature in recent releases.

So when this PRs is merged, and these:

then we can drop the audit-ignore for the time and chrono localtime_r rustsec entries.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 22, 2022
@syphar syphar merged commit e23ffc6 into rust-lang:master Dec 22, 2022
@syphar syphar deleted the less-chrono branch December 22, 2022 12:44
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 22, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants