Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace docs.rs theme setting #2464

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Namespace docs.rs theme setting #2464

merged 6 commits into from
Mar 19, 2024

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Mar 18, 2024

Fixes #2462 (at least issues from our side, the default theme now works as rustdoc implements it which may still not be what is wanted).

@Nemo157 Nemo157 requested a review from a team as a code owner March 18, 2024 10:49
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Mar 18, 2024
@GuillaumeGomez
Copy link
Member

Could add a GUI test for this please?

@Nemo157
Copy link
Member Author

Nemo157 commented Mar 18, 2024

@GuillaumeGomez there's no way to do multi-tab tests in goml-script is there?

@GuillaumeGomez
Copy link
Member

Not currently no. Each test is run into its own tab.

@Nemo157
Copy link
Member Author

Nemo157 commented Mar 18, 2024

Which is itself an issue since theming is cross-tab synchronized

@GuillaumeGomez
Copy link
Member

They don't share states apparently. Might be linked to how puppeteer handles it internally, otherwise rustdoc tests would have quite a lot of trouble since a lot of tests change the theme to check colors.

@GuillaumeGomez
Copy link
Member

Just some small improvements to be done to ensure the GUI test won't become flaky but otherwise looks good, thanks!

@Nemo157 Nemo157 force-pushed the namespace-docs.rs-theme branch from 93ff9d4 to 3c90b37 Compare March 18, 2024 15:30
@syphar
Copy link
Member

syphar commented Mar 19, 2024

@GuillaumeGomez @Nemo157 I didn't test anything here, but this PR is ready to be merged from your sides?

@GuillaumeGomez
Copy link
Member

Didn't test it but I'm confident thanks to the GUI test. ;)

@Nemo157
Copy link
Member Author

Nemo157 commented Mar 19, 2024

Yeah, I did some manual testing before the GUI test so this should be good to go.

@GuillaumeGomez
Copy link
Member

Then let's merge!

@GuillaumeGomez GuillaumeGomez enabled auto-merge (rebase) March 19, 2024 13:30
@GuillaumeGomez GuillaumeGomez merged commit 9c75442 into rust-lang:master Mar 19, 2024
8 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Mar 19, 2024
@Nemo157 Nemo157 deleted the namespace-docs.rs-theme branch March 19, 2024 16:39
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Default Theme Issue]: Ayu
3 participants
@Nemo157 @GuillaumeGomez @syphar