Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop length limitation for crate name & version #2510

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented May 19, 2024

this fixes this sentry error:

error trying to add rraaaaaaaaaaaaaaah-0.8.1+dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddexecrmrfzstd.1.5.0 to build queue

Error
db error: ERROR: value too long for type character varying(100)

From what I see, crates.io uses a plain VARCHAR without any length restrictions, I don't see why we can't do the same.

@syphar syphar requested a review from a team as a code owner May 19, 2024 14:32
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label May 19, 2024
Copy link

sentry-io bot commented May 19, 2024

Sentry Issue: DOCS-RS-BACKEND-AC

@syphar syphar force-pushed the drop-length branch 2 times, most recently from b0a8138 to 80665c9 Compare May 22, 2024 16:09
@syphar
Copy link
Member Author

syphar commented Jun 23, 2024

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Can you add a test please?

@syphar
Copy link
Member Author

syphar commented Jun 23, 2024

Can you add a test please?

done

@GuillaumeGomez
Copy link
Member

Please merge once clippy is happy.

@syphar syphar merged commit bbf1c3f into rust-lang:master Jun 24, 2024
7 checks passed
@syphar syphar deleted the drop-length branch June 24, 2024 05:56
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jun 24, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants