Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create rebuild queue #2651

Merged
merged 9 commits into from
Oct 25, 2024
Merged

create rebuild queue #2651

merged 9 commits into from
Oct 25, 2024

Conversation

zahidkizmaz
Copy link
Contributor

@zahidkizmaz zahidkizmaz commented Oct 22, 2024 •
edited
Loading

Descripton

This PR addresses the issue #2328

Creates a new section under: releases/queue page called Rebuild queue. By default it only shows the count with an option to click "Show" would reveal the queue.

Example screenshots:

Queue with 3 items expand unset:

20241022_08h19m51s_grim

Queue with 3 items and expand=1:

20241024_01h03m37s_grim

@zahidkizmaz zahidkizmaz requested a review from a team as a code owner October 22, 2024 06:18
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 22, 2024
syphar
syphar requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Two comments, and could to reword the commit message of the initial wip commit?

Generally we're doing rebase merges here

src/web/releases.rs Outdated Show resolved Hide resolved
templates/style/style.scss Outdated Show resolved Hide resolved
@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 23, 2024
@syphar
Copy link
Member

syphar commented Oct 24, 2024

@zahidkizmaz feel free to re-request reviews when you're ready

@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 24, 2024
@syphar syphar merged commit 22de827 into rust-lang:master Oct 25, 2024
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 25, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar approved these changes

@GuillaumeGomez GuillaumeGomez Awaiting requested review from GuillaumeGomez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zahidkizmaz @syphar @GuillaumeGomez