print current rust version on the about page #272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
Now that we're using a real nightly compiler to build docs, let's show the version somewhere. This PR takes the suggestion from the linked issue and prints the version of the rustc inside the container on the "about" page.
Open question: Would it be better to cache this version string somewhere (say, in the database or in some
lazy_static
) so we don't have to attach to the container and runrustc --version
every time someone loads the About page?