Skip to content

Fix source code UI bugs #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Apr 7, 2025

Two of the bugs can be seen here:

Screenshot From 2025-04-07 16-44-09

The last one is that the cursor was not the right one when hovering the toggle button, it's now fixed too.

I think it might help with #2787 but since I can't reproduce the bug, not sure...

Looks this now:

image

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner April 7, 2025 15:05
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 7, 2025
@GuillaumeGomez GuillaumeGomez force-pushed the fix-source-code-ui-bugs branch from 84fe197 to b44c1df Compare April 7, 2025 15:11
@GuillaumeGomez GuillaumeGomez force-pushed the fix-source-code-ui-bugs branch from b44c1df to 8c0aa1e Compare April 7, 2025 15:19
@GuillaumeGomez
Copy link
Member Author

And CI passed. :D

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix!

@syphar syphar merged commit 8f6921e into rust-lang:master Apr 12, 2025
9 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 12, 2025
@GuillaumeGomez GuillaumeGomez deleted the fix-source-code-ui-bugs branch April 12, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants