Skip to content

Replace x86_64-apple-darwin with aarch64-apple-darwin as default target #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace x86_64-apple-darwin with aarch64-apple-darwin as default target #2927

wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

Fixes #2926.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner October 1, 2025 15:18
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 1, 2025
@GuillaumeGomez
Copy link
Member Author

The failing tests are marked as "ignore"?

@syphar
Copy link
Member

syphar commented Oct 1, 2025

The failing tests are marked as "ignore"?

Ignore are the build tests. We didn't want to run them locally but only in ci.

So it's tests that need fixing.

That being said, I remember build tests on master are failing too, if they are the same on this PR it's unrelated to this change

syphar
syphar requested changes Oct 2, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the failing build-tests (ignored tests), one is also failing on master (test_no_implicit_features_for_optional_dependencies_with_dep_syntax), but another one is related to this PR and has to be fixed (test_build_crate).

One thing I'm not sure about:
wouldn't this be something like a breaking change where we need to inform crate authors?

@GuillaumeGomez
Copy link
Member Author

wouldn't this be something like a breaking change where we need to inform crate authors?

I guess it wouldn't hurt to do so. How are we supposed to announce it though? Rust blog post?

@GuillaumeGomez GuillaumeGomez force-pushed the replace-default-apple-target branch from 4458957 to 2d65f42 Compare October 2, 2025 09:45
@GuillaumeGomez
Copy link
Member Author

Fixed the test (the other one still fails).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make aarch64-apple-darwin a default target
2 participants
@GuillaumeGomez @syphar