redirect all *.ico paths to /favicon.ico #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
several rustdoc versions try to use rustdoc's built-in favicon, which overrides docs.rs's own favicon. instead of modifying these pages to remove the reference to their favicon, instead redirect them to the main favicon
|
Coming back to this PR, i want to take this version over the one in #330 (or a potential future one to use a planned CLI flag in rustdoc). This is probably the least invasive and least complicated way to load the favicon in, even if it creates more redirects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #330
This is an alternate version of that PR that routes ICO files to the default favicon instead of modifying documentation pages on-the-fly to remove the reference to the nonexistent favicon.