Skip to content

Conversation

@Mark-Simulacrum
Copy link
Member

Currently, we reuse the client for all files that are uploaded per call
to the relevant code. Unfortunately, S3 will prevent connections from
being long-lived (it's unknown what the exact timeout is, but we hit it
relatively rarely). This code attempts to retry S3 uploads up to 3 times
while replacing the client each time.

r? @QuietMisdreavus

Currently, we reuse the client for all files that are uploaded per call
to the relevant code. Unfortunately, S3 will prevent connections from
being long-lived (it's unknown what the exact timeout is, but we hit it
relatively rarely). This code attempts to retry S3 uploads up to 3 times
while replacing the client each time.
@Mark-Simulacrum
Copy link
Member Author

I ran update queue set attempt = 100 where name = 'alt-stm32f30x-hal'; on the DB to temporarily stop building that crate, as we had been attempting to do so for the last 7-10 hours I believe and failing on the upload each time. We'll want to undo that with update queue set attempt = 0 where name = 'alt-stm32f30x-hal'; after deploying this.

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@QuietMisdreavus QuietMisdreavus merged commit 76a2c72 into rust-lang:master Jul 22, 2019
@Mark-Simulacrum Mark-Simulacrum deleted the fix-s3-longlived branch July 22, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants