Fix uploads of large crates to S3 breaking the client #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we reuse the client for all files that are uploaded per call
to the relevant code. Unfortunately, S3 will prevent connections from
being long-lived (it's unknown what the exact timeout is, but we hit it
relatively rarely). This code attempts to retry S3 uploads up to 3 times
while replacing the client each time.
r? @QuietMisdreavus