Keep the subpage when going to latest version #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I haven't found a test case for an item that was deleted/moved between versions, if anyone knows of one please let me know! |
|
Fixed the bug with a different platform. I've tested the following manually:
If anyone has suggestions for how to set up unit tests, I'd be happy to hear them! I'm not sure how to ensure that certain crates exist in the database :/ |
jyn514
changed the title
|
This does not address the following issues:
|
|
This is ready for review. |
|
This is fantastic, thanks so much @jyn514 |
Addresses rust-lang#200 If the page does not exist on the latest version, searches for a page with that title.
Previously, if 1. Going to a new version that 2. Deleted the existing module/item and 3. The user is looking at a platform other than the default, then the link was wrong. This is now fixed.
jyn514
force-pushed
the
latest-version
branch
from
992f870 to
e862706
Compare
|
Added comments as requested :) Thanks for taking a look at this! |
QuietMisdreavus
approved these changes
Nov 12, 2019
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #200
If the page does not exist on the latest version, searches for a page with that title.
~~TODO: If
then the link will be wrong (it will not include the name of the crate).~~
The solution is to check ifreq_path[3]is the crate name or the platform. Once this is done, #200 (comment) will be trivial to fix.This is fixed, see below.