Fix redirects if latest version failed to build #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, to double check what this PR does:
Would it be possible to check for the presence of the query string and only include the |
|
Yes, that's right. I can change it to remove the '?' if there's no query, give me a second. |
|
Ok should be fixed. |
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
failed-build-search
branch
from
e72902f to
e662e56
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closes rust-lang#502 The redirector behaved differently for `/:crate/:version/:target` than for `/:crate/:version/:target/`. This changes the latest version link to use the former, since it properly accounts for failed builds. Additionally, this changes the `/:target` redirect to keep the query parameter so that `?search=` URLs will be kept.
- add query parameter if it exists - don't call `env.frontend()` a dozen times - add tests
jyn514
force-pushed
the
failed-build-search
branch
from
e662e56 to
1934869
Compare
|
This is ready for review. |
|
r? @kvrhdn |
|
Sure @jyn514, I should be able to check out these changes this weekend 🙂 |
yvrhdn
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #502
The redirector behaved differently for
/:crate/:version/:targetthanfor
/:crate/:version/:target/. This changes the latest version link touse the former, since it properly accounts for failed builds.
Additionally, this changes the
/:targetredirect to keep the queryparameter so that
?search=URLs will be kept when going to/:target/.r? @QuietMisdreavus
Some good crates to test this with: