Remove unused code #558
Merged
Remove unused code #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
force-pushed
the
remove-unused-code
branch
from
9ad0f91 to
729cb76
Compare
jyn514
force-pushed
the
remove-unused-code
branch
from
27421e7 to
7cb0a07
Compare
|
r? @koenaad There's lots of messing with |
|
Oh hey, sorry @jyn514. I didn't see this mention between all my Github notifications. I should probably tweak my github settings a bit... |
yvrhdn
approved these changes
Feb 5, 2020
Co-Authored-By: Koenraad Verheyden <mail@koenraadverheyden.com>
this was causing confusion, see rust-lang#164
|
Addressed review comments |
|
Cool! Looks good to me. Again, great work making the docs.rs codebase a bit easier to work with 😄 |
jyn514
added a commit
that referenced
this pull request
Feb 6, 2020
This reverts commit 3809f94. This caused all builds to fail in the last step when copying documentation into the database.
jyn514
added a commit
that referenced
this pull request
Feb 6, 2020
This reverts commit 3809f94. This caused all builds to fail in the last step when copying documentation into the database.
jyn514
added a commit
to jyn514/docs.rs
that referenced
this pull request
Feb 6, 2020
* remove copy_dir * make utils pub(crate) where possible * remove dead code in rustc version * make more things pub(crate) * only compile ApplyMode::Temporary in test mode * remove unused argument * remove unused `handle_html` argument * don't export metadata * remove `pub` where possible * remove unused import * make create_pool pub(crate) * fix bad merge * pub(crate) doesn't make sense in lib.rs Co-Authored-By: Koenraad Verheyden <mail@koenraadverheyden.com> * address review comments re: copy test * remote system dependencies from metadata this was causing confusion, see rust-lang#164 * re-comment failing test * fix failing test Co-authored-by: Koenraad Verheyden <mail@koenraadverheyden.com>
jyn514
added a commit
that referenced
this pull request
Feb 8, 2020
* remove copy_dir * make utils pub(crate) where possible * remove dead code in rustc version * make more things pub(crate) * only compile ApplyMode::Temporary in test mode * remove unused argument * remove unused `handle_html` argument * don't export metadata * remove `pub` where possible * remove unused import * make create_pool pub(crate) * fix bad merge * pub(crate) doesn't make sense in lib.rs Co-Authored-By: Koenraad Verheyden <mail@koenraadverheyden.com> * address review comments re: copy test * remote system dependencies from metadata this was causing confusion, see #164 * re-comment failing test * fix failing test Co-authored-by: Koenraad Verheyden <mail@koenraadverheyden.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.