Allow non-tier-one targets to be built #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the outdated x32 apple target
jyn514
changed the title
|
I didn't look at this PR too closely yet, but we'll also want to implement limits to avoid people building tons of targets. The limit should be overridable through the usual sandbox limits mechanism. |
|
Ah, good idea. Does 10 sounds like a reasonable limit? We currently build 6 so it's the same order of magnitude. |
|
Yeah that sounds fine. We'll also need to update the issue template for sandbox limit increases. |
|
Added a default limit of 10 targets and updated /about and the issue template. |
|
You didn't update the schema. |
|
I need to test locally that the schema change is right, one second. |
Co-Authored-By: Pietro Albini <pietro@pietroalbini.org>
pietroalbini
approved these changes
Mar 17, 2020
This was referenced Mar 17, 2020
bors bot
added a commit
to rust-embedded/cortex-m
that referenced
this pull request
Aug 23, 2020
256: Add embedded targets to docs.rs r=jonas-schievink a=hug-dev Some modules of this repo are gated by the various targets and hence docs.rs does not show the documentation for them! Like the Armv8-M ones for [example](#217 (comment)) and the `cmse` module. docs.rs now allows building for specific target and since [this PR](rust-lang/docs.rs#633) even for targets available via `rustup`! The `stm32f3_discovery` crate does it, look at ["Platform" on docs.rs](https://docs.rs/stm32f3-discovery/0.4.0/stm32f3_discovery/index.html). So I think it would be very neat to have on `cortex-m` and I proposing to add the following targets. The first one will show by default, I choosed the latest and greatest for that 😄 I tested locally with `cargo doc --target ...` for all of them. Co-authored-by: Hugues de Valon <hugues.devalon@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #563.
Waiting on #632.Merged.This uses rustup to install toolchains if they are not already installed. These toolchains will be removed on the next toolchain update, and will be downloaded again on request.
Only the last few commits are related to #563, all others are from #632.