Skip to content

Refactor add_package.rs #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Apr 2, 2020

  • Made the function signatures readable (Still need further work with splitting into separate functions)
  • Changed passing integers by reference into passing them directly, pointers are larger than i32s
  • Overall style and formatting changes

@jyn514
Copy link
Member

jyn514 commented Apr 3, 2020

As discussed on discord, I think having one principled rustfmt PR would be better than formatting piecemeal and mixing it with other clippy lints/style issues. I'm happy to take this change:

Changed passing integers by reference into passing them directly, pointers are larger than i32s

but I think the rest are not the best direction for docs.rs at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants