Skip to content

Put back tab index on top crate search input #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020

Conversation

GuillaumeGomez
Copy link
Member

Fixes #118

@antoyo
Copy link

antoyo commented May 3, 2020

Can you add a comment to explain why we do this so that is does not get removed again in the future?

@GuillaumeGomez
Copy link
Member Author

You mean in the HTML?

@antoyo
Copy link

antoyo commented May 3, 2020

It's a template, so it could be a template comment, so it won't be in the generated HTML.

@GuillaumeGomez
Copy link
Member Author

Yes, my bad for the incomplete answer. That's what I meant. ;)

@GuillaumeGomez
Copy link
Member Author

Updated!

@jyn514
Copy link
Member

jyn514 commented May 18, 2020

This one fell through the cracks, sorry. Thanks for working on this!

@jyn514 jyn514 merged commit 59efdb3 into rust-lang:master May 18, 2020
@jyn514
Copy link
Member

jyn514 commented May 18, 2020

@antoyo I just deployed the change, do you mind visiting the site to see whether the problem is fixed?

@antoyo
Copy link

antoyo commented May 18, 2020

@jyn514: it works fine. Thanks.

@GuillaumeGomez GuillaumeGomez deleted the tabindex branch May 18, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the search crate text field by default
3 participants