Skip to content

Added max pool size metric #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

Added max pool size metric #774

merged 1 commit into from
May 27, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented May 26, 2020

No description provided.

@jyn514
Copy link
Member

jyn514 commented May 27, 2020

r? @pietroalbini

This looks good to me, though. Context from discussions on discord:

pietro: a docsrs_max_db_connections metric would be useful so we can setup an alert for 75% used database connections (I don't want to hardcode 90 connections in the monitoring). The current idle+used is not 90.

@pietroalbini
Copy link
Member

Thanks!

@pietroalbini pietroalbini merged commit 2df74ac into rust-lang:master May 27, 2020
@Kixiron Kixiron mentioned this pull request May 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kixiron @jyn514 @pietroalbini