Skip to content

Migrate to Tera #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jul 13, 2020
Merged

Migrate to Tera #887

merged 30 commits into from
Jul 13, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Jul 7, 2020

Fixup of #879

  • Fixed ISEs from rustdoc & details page, tera errors on OOB indexes while handlebars doesn't
  • Highlighting was corrected, rustdoc provides its own link
  • All builds are not shown as failed link
  • Fixed issue with rendering crate pages: details.rustdoc must be piped to safe link
Fixed page

image

Closes #884

Kixiron added 25 commits July 4, 2020 18:30
jyn514
jyn514 reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for all the bugs you fixed. The highlight.js one might be tricky but all the others should be doable.

@Kixiron
Copy link
Member Author

Kixiron commented Jul 8, 2020

None are possible to be tested without full builds and full ui testing. Ui testing will be a follow up, it’s been blocked on this for a while

@pietroalbini
Copy link
Member

We can definitely test them without full UI tests: just use kuchiki to parse the HTML returned by the web server, like I did in this test.

@jyn514 jyn514 added A-frontend Area: Web frontend P-high High priority labels Jul 12, 2020
@jyn514 jyn514 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 12, 2020
@jyn514
Copy link
Member

jyn514 commented Jul 12, 2020

Marking as P-high since this is blocking #873.

@jyn514
Copy link
Member

jyn514 commented Jul 13, 2020

Everything but highlight.js now has tests (since I'm not really sure how to test CSS without full UI tests).

@Kixiron
Copy link
Member Author

Kixiron commented Jul 13, 2020

I don't think the highlighting is a massive deal for now, it's not a breakage so much as an annoyance (That is, it doesn't break anything or hinder site usage, it just doesn't look as good)

@jyn514
Copy link
Member

jyn514 commented Jul 13, 2020

Yeah, I'm fine merging this as-is if you've tested locally it's fixed now.

@jyn514 jyn514 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 13, 2020
@Kixiron
Copy link
Member Author

Kixiron commented Jul 13, 2020

Tested locally and we're all good

jyn514
jyn514 reviewed Jul 13, 2020
View reviewed changes
@Kixiron
Update templates/macros.html
171d4f4 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@jyn514 jyn514 merged commit 81069b6 into rust-lang:master Jul 13, 2020
@Kixiron Kixiron mentioned this pull request Jul 13, 2020
Closed
12 tasks
This was referenced Jul 13, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees
No one assigned
Labels
A-frontend Area: Web frontend P-high High priority S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CrateDetails should not be optional
3 participants
@Kixiron @pietroalbini @jyn514