Add rustfmt when installing a new toolchain #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example build:
```
2020/07/26 20:02:52 [INFO] rustwide::toolchain: adding component rustfmt for toolchain nightly
2020/07/26 20:02:52 [INFO] rustwide::cmd: running `Command { std: "/home/joshua/src/rust/docs.rs/.rustwide/cargo-home/bin/rustup" "component" "add" "--toolchain" "nightly" "rustfmt", kill_on_drop: false }`
2020/07/26 20:02:53 [INFO] rustwide::cmd: [stderr] info: downloading component 'rustfmt'
2020/07/26 20:02:54 [INFO] rustwide::cmd: [stderr] info: installing component 'rustfmt'
```
This was tested by building `fermium 0.0.11` with the new changes.
I have not tested the upgrade behavior, so possibly this shouldn't be
merged until I do that.
jyn514
changed the title
Nemo157
reviewed
Jul 27, 2020
| @@ -166,6 +166,9 @@ impl RustwideBuilder { | |||
| for target in &targets_to_install { | |||
| self.toolchain.add_target(&self.workspace, target)?; | |||
| } | |||
| // NOTE: rustup will automatically refuse to update the toolchain | |||
| // if `rustfmt` is not available in the newer version | |||
There was a problem hiding this comment.
Do we want this behavior, or should we not block the update on it and only have optional rustfmt support? This will currently result in occasionally having like a week without updating the nightly.
There was a problem hiding this comment.
I think going a week without updating is better than having rustfmt support you can only sometimes depend on. See #357 (comment).
jyn514
added
A-builds
pietroalbini
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example build:
This was tested by building
fermium 0.0.11with the new changes. I made sure rustfmt was actually visible to the crate by looking at the generated source. Here is/fermium/0.0.11/src/fermium/opt/rustwide/target/debug/build/fermium-d794f31f687205c6/out/bindings.rs.html#714-726:I have not tested the upgrade behavior, so possibly this shouldn't be
merged until I do that.
Closes #357.
r? @pietroalbini