-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate dependencies #929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes 4 dependencies, including two duplicate copies of `syn` and `quote`. ``` $ cargo update -p comrak Updating crates.io index Updating comrak v0.3.1 -> v0.8.0 Removing pest v1.0.6 Removing pest_derive v1.0.8 Removing quote v0.3.15 Removing syn v0.11.11 Removing synom v0.11.3 Adding twoway v0.2.1 Adding unchecked-index v0.2.2 Removing unicode-xid v0.0.4 ``` - Remove `safe = true` This was made the default in 0.4.0. The field is now called `unsafe_`. https://github.com/kivikakk/comrak/blob/master/changelog.txt#L63
It drags in a ton of dependencies and can be trivially rewritten with `url`. ``` $ cargo update -p params Removing autocfg v0.1.7 Removing bodyparser v0.8.0 Removing buf_redux v0.6.3 Removing mime_guess v1.8.8 Removing multipart v0.13.6 Removing num v0.1.42 Removing num-bigint v0.1.44 Removing num-complex v0.1.43 Removing num-iter v0.1.40 Removing num-rational v0.1.42 Removing params v0.8.0 Removing persistent v0.4.0 Removing phf_codegen v0.7.24 Removing phf_generator v0.7.24 Removing rand v0.6.5 Removing rand_chacha v0.1.1 Removing rand_hc v0.1.0 Removing rand_isaac v0.1.1 Removing rand_jitter v0.1.4 Removing rand_os v0.1.3 Removing rand_pcg v0.1.2 Removing rand_xorshift v0.1.1 Removing tempdir v0.3.7 Removing twoway v0.1.8 Removing urlencoded v0.6.0 ```
``` $ cargo update -p postgres Updating crates.io index Removing base64 v0.6.0 Removing block-buffer v0.3.3 Removing byte-tools v0.2.0 Removing bytes v0.4.12 Adding cloudabi v0.1.0 Removing crypto-mac v0.5.2 Removing digest v0.7.6 Updating fallible-iterator v0.1.6 -> v0.2.0 Removing fuchsia-cprng v0.1.1 Removing generic-array v0.9.0 Removing hex v0.2.0 Removing hmac v0.5.0 Adding instant v0.1.6 Updating libc v0.2.70 -> v0.2.74 Adding lock_api v0.4.1 Removing md5 v0.3.8 Adding parking_lot v0.11.0 Adding parking_lot_core v0.8.0 Removing phf v0.7.24 Removing phf_shared v0.7.24 Updating postgres v0.15.2 -> v0.17.5 Updating postgres-protocol v0.3.2 -> v0.5.2 Removing postgres-shared v0.4.2 Adding postgres-types v0.1.2 Updating r2d2_postgres v0.14.0 -> v0.16.0 Removing rand v0.3.23 Removing rand v0.4.6 Removing rand_core v0.3.1 Removing rand_core v0.4.2 Removing rdrand v0.4.0 Removing safemem v0.2.0 Updating schemamama_postgres v0.2.4 -> v0.3.0 Removing sha2 v0.7.1 Removing siphasher v0.2.3 Adding tokio-postgres v0.5.5 ``` - Change &Connection to &mut Connection - Add `NoTls` type parameter to connection manager - Use `String.as_str()` instead of `&String` to help type inference - Temporarily `use Client as Connection` - Use `row.try_get()` instead of `row.get_opt()` - Use `rows[0]` instead of `rows.get(0)` - Various other small changes
jyn514
added
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
P-medium
Medium priority
C-technical-debt
Category: This makes the code harder to read and modify, but has no impact on end users
labels
Aug 2, 2020
Duplicates before
Duplicates after
|
jyn514
added
the
A-newcomer-roadblock
Area: A problem that isn't a bug, but makes it harder for people to contribute
label
Aug 2, 2020
Nemo157
approved these changes
Aug 3, 2020
A few messy bits of reformatting, but they can be fixed when they next get touched |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-newcomer-roadblock
Area: A problem that isn't a bug, but makes it harder for people to contribute
C-technical-debt
Category: This makes the code harder to read and modify, but has no impact on end users
P-medium
Medium priority
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of #459. Most of the churn comes from the 3rd commit upgrading to postgres 0.17. This is best reviewed commit-by-commit.
On the bright side, this removes 59 of 90 duplicate dependencies.