Improve the styling of the coverage in the dropdown #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pietroalbini this looks great! Appreciate you being open to this @GuillaumeGomez. I definitely agree with the overall goal of getting people to write more docs and it will be awesome to see more tools/metrics come out to help with that. :) |
|
Like I said, I don't completely agree with this change but if it makes people more at ease with this feature, this is acceptable. |
jyn514
added
A-frontend
GuillaumeGomez
approved these changes
Aug 12, 2020
|
Looks like you need to update the tests too: Looks fine to me other than that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New styling (the text is clickable and leads to the crate page):
r? @GuillaumeGomez
cc @yaahc @sunjay