Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that edition can be set in a Cargo workspace #45

Closed
djc opened this issue Jun 24, 2018 · 6 comments
Closed

Clarify that edition can be set in a Cargo workspace #45

djc opened this issue Jun 24, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request p-low
Milestone

Comments

@djc
Copy link

djc commented Jun 24, 2018

This seems to work, but is not mentioned in the guide (in transitioning.html):

cargo-features = ["edition"]

[workspace]
members = ["askama", "askama_derive", "askama_shared", "testing"]
edition = "2018"

Obviously, adding it one place instead of per-crate is rather attractive!

@steveklabnik steveklabnik added the enhancement New feature or request label Jun 25, 2018
@Mark-Simulacrum Mark-Simulacrum added this to the Preview 2 milestone Jul 10, 2018
@Centril Centril added the p-low label Jul 10, 2018
@ehuss
Copy link
Contributor

ehuss commented Jul 13, 2018

I don't think this is correct. edition is ignored in a virtual manifest. All unknown keys are ignored (there is issue rust-lang/cargo#4243 to add a warning).

@djc
Copy link
Author

djc commented Jul 14, 2018

Hmm, I seem to remember I actually verified that it was doing this. If it's not currently implemented, it would sure be nice to implement.

@steveklabnik
Copy link
Member

From IRC:

20:39 < ehuss> @steveklabnik: fwiw, I added a warning a few days ago that the key is ignored.

So, seems like we can close this one.

@Centril
Copy link
Contributor

Centril commented Jul 24, 2018

Hmm... can we make the key not be ignored and actually use it? That seems very useful for larger projects...

@steveklabnik
Copy link
Member

That discussion belongs on Cargo's tracker, not here.

@Centril
Copy link
Contributor

Centril commented Jul 24, 2018

That's true :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p-low
Projects
None yet
Development

No branches or pull requests

5 participants