-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting edition = "2018"
in a workspace
#5784
Comments
Like #5661, but less granular 🙂. (I mention it also because one might want to tackle these in one swing.) |
Especially since |
With the new edition coming next year, we should look into implementing this. @ehuss Are there any blockers for this? |
I believe it is being implemented as part of #8664. |
#9684 seems to be the relevant PR now. Also bump, since the 2021 edition is coming up, and this could be relevant for migration. |
Would #8415 be a viable solution for this? You would set |
Yea, I think RFC 2906 is the solution to this. There was a lot of discussion in RFC 2906 about whether or not workspace fields should be implicitly inherited, and it was decided that it is best to not make anything implicit, edition in particular. It looks like the edition field is already supported, so closing in favor of #8415. |
For larger projects, it could be useful to set the edition once instead of in each project's
Cargo.toml
file. This would then be equivalent to setting the edition key in every member project in the workspace.Currently, the edition key is ignored instead: #5726
See also: rust-lang/edition-guide#45
The text was updated successfully, but these errors were encountered: