-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2018-specific changes. #130
Conversation
Some notes:
|
Good points, thanks for taking a look! |
This would be lovely to land, it took me quite some digging before I realised that NLL is edition 2018 only. As a side note, I couldn't figure out how to specify the edition to |
Thank you! People have been asking about this for a while. I think this is a fine place to put it, we can iterate if it turns out to be not ideal in practice. |
Now that Rust nightly is fixed, could someone rerun the merge build for this so it deploys, please? Thank you! https://travis-ci.com/rust-lang-nursery/edition-guide/builds/96925518 |
I poked it, |
Update edition-guide 15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e 2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800 - Migrate to mdbook 0.2. (rust-lang/edition-guide#152) - Remove automatic deployment. (rust-lang/edition-guide#151) - Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147) - Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148) - overflowing_literals is deny on all editions (rust-lang/edition-guide#146) - Update for uniform_path stabilization. (rust-lang/edition-guide#141) - Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144) - Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142) - Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137) - Add 2018-specific changes. (rust-lang/edition-guide#130) - aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125) - Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124) - update several version numbers - Fixes outdated link (rust-lang/edition-guide#131) - Fixed typo in transitioning page. (rust-lang/edition-guide#127)
Update edition-guide 15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e 2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800 - Migrate to mdbook 0.2. (rust-lang/edition-guide#152) - Remove automatic deployment. (rust-lang/edition-guide#151) - Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147) - Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148) - overflowing_literals is deny on all editions (rust-lang/edition-guide#146) - Update for uniform_path stabilization. (rust-lang/edition-guide#141) - Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144) - Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142) - Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137) - Add 2018-specific changes. (rust-lang/edition-guide#130) - aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125) - Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124) - update several version numbers - Fixes outdated link (rust-lang/edition-guide#131) - Fixed typo in transitioning page. (rust-lang/edition-guide#127)
Closes #91.