-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hyphenation of “Rust-version–aware” #359
base: master
Are you sure you want to change the base?
Conversation
@epage Can you review this? I assume the intent was to stay consistent with the key name. |
From my understanding this is changing
For myself, as a native english speaker, I did not know any of this and I feel this adherence to english rules can get in the way of communication. I suspect it will be even worse for english-as-a-second-langage. The visual distinction between a hyphen, an en-dash, an em-dash, etc is very minor and I expect most people will not notice, especially when not next to each other. I also wonder how many people are like me and are unaware of these rules. In that context, seeing We could find an alternative way of phrasing this to avoid this conflict between correctness and clarity but I worry that will lead to a verbosity that will also get in the way. |
Hmm, looking further on wikipedia,
It makes it sound like |
I also think “Rust-version–aware resolver” reads well, so I updated it to that. |
We seem to be discussing two different things here:
Regarding (1): we are describing a "dependency resolver" that is aware of the Rust versions (as opposed to saying the resolver is aware of "versions", abstractly). Therefore the three words "rust version aware" are a single phrasal adjective. Ordinarily, all words in a single phrasal adjective would be hyphenated, so we would have "rust-version-aware resolver". However, there is a special case for proper nouns, in this case "Rust". Garner1 states (under As the currently published edition is written, "Rust" is capitalized, meaning that the author was referring to Rust the programming language, which has assigned versions, rather than Alternatively, the clause (currently written as) "...which enables a Rust-version aware dependency resolver." could simply be changed to "...which enables a dependency resolver that is aware of Rust versions." That would keep "Rust" as a proper noun, but would avoid the phrasal adjective. There is also a case that could be made for removing the proper noun "Rust". Since the key name in a Regarding (2): I don't think Markdown is the proper place to get too deeply into typography, as it is intended to be "used like email" and different renderers will do different things. I would suggest just sticking with ASCII/Unicode Summary:
Thoughts? Footnotes
|
Note that the Rust version resolver respects the |
In standard English grammar, the way to hyphenate “Rust version” and “aware” is by using an en dash (https://en.wikipedia.org/wiki/Dash#Attributive_compounds). Inserting a hyphen between “Rust” and “version” isn’t right since the phrase is not usually hyphenated.
An alternative is to write
rust-version
-aware, i.e. specifically referring to the Cargo key. Not sure if that was the intent here.