Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clap to v4 #53

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Update clap to v4 #53

merged 1 commit into from
Mar 30, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 14, 2024

No description provided.

@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2024

This PR unfortunately needs a rebase due to #54

@dtolnay
Copy link
Member Author

dtolnay commented Mar 30, 2024

Rebased.

@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2024 •
edited
Loading

Thanks! I appreciate it ❤️

edit: looks like there's a new merge conflict 😅

@dtolnay
Copy link
Member Author

dtolnay commented Mar 30, 2024

Indeed, it was the import for PathBuf. Fixed.

@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2024

Thanks!

@lcnr lcnr merged commit f7374a4 into rust-lang:main Mar 30, 2024
5 checks passed
@dtolnay dtolnay deleted the clap branch March 30, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtolnay @lcnr