Skip to content

Partial gzip header breaks decoding #320

@jongiddy

Description

@jongiddy

The read_gz_header_part function returns an Err if the first 10 bytes of the gzip header are not present or if the FEXTRA flag is set and the extra fields are not present. Returning an Err causes GzDecoder::write to keep the buffer and wait for more data to complete the header.

However, if the header contains an optional filename or comment but they are not completely contained in the buffer, then a valid header is created, missing data from the optional sections. The next write call will treat the remaining header as encoded data and attempt to unzip it.

The problem occurs because for byte in r.bytes() ends the iteration when the end of the buffer is found, falling through to the next state.

If this happens, the code should return Err(io::ErrorKind::UnexpectedEof) to allow a subsequent write to complete the header.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions