Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable compilation of miniz-sys on WASI #194

Merged
merged 1 commit into from
May 16, 2019

Conversation

RReverser
Copy link
Contributor

This aligns build script conditions with all the #[cfg(...)] conditions in that miniz-sys shouldn't be attempted to be compiled on WASI target.

In particular, this previously caused library to fail to compile to wasm32-unknown-wasi target from a Windows host.

@RReverser
Copy link
Contributor Author

error: toolchain 'stable-x86_64-unknown-linux-gnu' does not contain component 'rust-std' for target 'wasm32-unknown-wasi'

Hmm, what did I do wrong?

@bjorn3
Copy link
Member

bjorn3 commented May 16, 2019

I believe stable doesnt support wasi yet.

@RReverser
Copy link
Contributor Author

Switched to nightly, but still the same issue:

error: toolchain 'nightly-x86_64-unknown-linux-gnu' does not contain component 'rust-std' for target 'wasm32-unknown-wasi'

@bjorn3
Copy link
Member

bjorn3 commented May 16, 2019

The target was renamed to wasm32-wasi a few days ago.

@RReverser
Copy link
Contributor Author

Oh wow. That looks unusual / inconsistent with other target names (at least it's not a triple anymore). Why was it changed?

@bjorn3
Copy link
Member

bjorn3 commented May 16, 2019

rust-lang/rust#60585

This follows aarch64-linux-android, x86_64-fuchsia, and others in
omitting the vendor field, which has the advantage of aligning with the
multiarch tuple, and of being
less noisy.

This aligns build script conditions with all the `#[cfg(...)]` conditions in that miniz-sys shouldn't be attempted to be compiled on WASI target.

In particular, this previously caused library to fail to compile to wasm32-wasi target from a Windows host.
@RReverser
Copy link
Contributor Author

@alexcrichton Should be ready now! @bjorn3 thanks for the help!

@alexcrichton alexcrichton merged commit cc85538 into rust-lang:master May 16, 2019
@RReverser
Copy link
Contributor Author

@alexcrichton Could you please make a release when you have time?

@RReverser RReverser deleted the wasi branch May 16, 2019 15:53
@bjorn3
Copy link
Member

bjorn3 commented May 16, 2019

@RReverser I can point wasi-rustc to git until a release has been made. I did the same for measureme.

@RReverser
Copy link
Contributor Author

@bjorn3 Yeah sure, I know about that workaround, just asked to make sure this is released at some near point in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants