New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset StreamWrapper after calling mz_inflate / mz_deflate #380

Merged

Byron merged 1 commit into rust-lang:main from Manishearth:reset-stream

Oct 13, 2023

Member

Manishearth commented Oct 12, 2023

Fixes #379

This was referenced Oct 12, 2023

unsafe review: Potential (not actual) dangling pointers after inflate/deflate #379

Closed

prepare next patch-release #378

Merged


          Reset StreamWrapper after calling mz_inflate / mz_deflate

7a61ea5

Manishearth force-pushed the reset-stream branch from 5314cf1 to 7a61ea5 Compare

October 12, 2023 16:22

Member Author

Manishearth commented Oct 12, 2023

Byron approved these changes

View reviewed changes

Member

Byron left a comment

Thanks a lot for your help!

I looked for a while to see if anybody would be relying on avail_in and avail_out and if these are changed after the C call, but came up empty. All tests pass as well so this is probably the way to do it.

Byron merged commit 223f829 into rust-lang:main

10 checks passed

bors referenced this pull request in rust-lang/cargo


          Auto merge of #12905 - rust-lang:renovate/compatible, r=epage

3dd00d1

chore(deps): update compatible

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [base64](https://togithub.com/marshallpierce/rust-base64) | workspace.dependencies | patch | `0.21.4` -> `0.21.5` |
| [cargo_metadata](https://togithub.com/oli-obk/cargo_metadata) | workspace.dependencies | patch | `0.18.0` -> `0.18.1` |
| [clap](https://togithub.com/clap-rs/clap) | workspace.dependencies | patch | `4.4.6` -> `4.4.7` |
| [flate2](https://togithub.com/rust-lang/flate2-rs) | workspace.dependencies | patch | `1.0.27` -> `1.0.28` |
| [jobserver](https://togithub.com/alexcrichton/jobserver-rs) | workspace.dependencies | patch | `0.1.26` -> `0.1.27` |
| [libc](https://togithub.com/rust-lang/libc) | workspace.dependencies | patch | `0.2.148` -> `0.2.149` |
| [serde](https://serde.rs) ([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies | patch | `1.0.188` -> `1.0.190` |
| [serde_json](https://togithub.com/serde-rs/json) | workspace.dependencies | patch | `1.0.107` -> `1.0.108` |
| [snapbox](https://togithub.com/assert-rs/trycmd/tree/main/crates/snapbox) ([source](https://togithub.com/assert-rs/trycmd)) | workspace.dependencies | patch | `0.4.13` -> `0.4.14` |
| [syn](https://togithub.com/dtolnay/syn) | workspace.dependencies | patch | `2.0.37` -> `2.0.38` |
| [tempfile](https://stebalien.com/projects/tempfile-rs/) ([source](https://togithub.com/Stebalien/tempfile)) | workspace.dependencies | patch | `3.8.0` -> `3.8.1` |
| [thiserror](https://togithub.com/dtolnay/thiserror) | workspace.dependencies | patch | `1.0.49` -> `1.0.50` |
| [toml](https://togithub.com/toml-rs/toml) | workspace.dependencies | patch | `0.8.2` -> `0.8.6` |
| [tracing](https://tokio.rs) ([source](https://togithub.com/tokio-rs/tracing)) | workspace.dependencies | patch | `0.1.37` -> `0.1.40` |

---

### Release Notes

<details>
<summary>marshallpierce/rust-base64 (base64)</summary>

### [`v0.21.5`](https://togithub.com/marshallpierce/rust-base64/blob/HEAD/RELEASE-NOTES.md#0215)

[Compare Source](https://togithub.com/marshallpierce/rust-base64/compare/v0.21.4...v0.21.5)

-   Add `Debug` and `Clone` impls for the general purpose Engine

</details>

<details>
<summary>oli-obk/cargo_metadata (cargo_metadata)</summary>

### [`v0.18.1`](https://togithub.com/oli-obk/cargo_metadata/compare/0.18.0...0.18.1)

[Compare Source](https://togithub.com/oli-obk/cargo_metadata/compare/0.18.0...0.18.1)

</details>

<details>
<summary>clap-rs/clap (clap)</summary>

### [`v4.4.7`](https://togithub.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#447---2023-10-24)

[Compare Source](https://togithub.com/clap-rs/clap/compare/v4.4.6...v4.4.7)

##### Performance

-   Reduced code size

</details>

<details>
<summary>rust-lang/flate2-rs (flate2)</summary>

### [`v1.0.28`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.28)

[Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.27...1.0.28)

#### What's Changed

-   Use explicit Default for GzHeaderState enum by [`@&#8203;jongiddy](https://togithub.com/jongiddy)` in [https://github.com/rust-lang/flate2-rs/pull/371](https://togithub.com/rust-lang/flate2-rs/pull/371)
-   Fix spare capacity handling by [`@&#8203;anforowicz](https://togithub.com/anforowicz)` in [https://github.com/rust-lang/flate2-rs/pull/373](https://togithub.com/rust-lang/flate2-rs/pull/373)
-   Fix and unify docs of `bufread` and `read` types. by [`@&#8203;georeth](https://togithub.com/georeth)` in [https://github.com/rust-lang/flate2-rs/pull/375](https://togithub.com/rust-lang/flate2-rs/pull/375)
-   Reset StreamWrapper after calling mz_inflate / mz_deflate by [`@&#8203;Manishearth](https://togithub.com/Manishearth)` in [https://github.com/rust-lang/flate2-rs/pull/380](https://togithub.com/rust-lang/flate2-rs/pull/380)
-   prepare next patch-release by [`@&#8203;Byron](https://togithub.com/Byron)` in [https://github.com/rust-lang/flate2-rs/pull/378](https://togithub.com/rust-lang/flate2-rs/pull/378)

#### New Contributors

-   [`@&#8203;anforowicz](https://togithub.com/anforowicz)` made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/373](https://togithub.com/rust-lang/flate2-rs/pull/373)
-   [`@&#8203;georeth](https://togithub.com/georeth)` made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/375](https://togithub.com/rust-lang/flate2-rs/pull/375)
-   [`@&#8203;Manishearth](https://togithub.com/Manishearth)` made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/380](https://togithub.com/rust-lang/flate2-rs/pull/380)

**Full Changelog**: rust-lang/flate2-rs@1.0.27...1.0.28

</details>

<details>
<summary>rust-lang/libc (libc)</summary>

### [`v0.2.149`](https://togithub.com/rust-lang/libc/releases/tag/0.2.149)

[Compare Source](https://togithub.com/rust-lang/libc/compare/0.2.148...0.2.149)

#### What's Changed

-   libc 0.2.148 by [`@&#8203;joshtriplett](https://togithub.com/joshtriplett)` in [https://github.com/rust-lang/libc/pull/3351](https://togithub.com/rust-lang/libc/pull/3351)
-   update libc-test and its libc dependency to 0.2.148 by [`@&#8203;chenx97](https://togithub.com/chenx97)` in [https://github.com/rust-lang/libc/pull/3314](https://togithub.com/rust-lang/libc/pull/3314)
-   Disable 1.13 CI by [`@&#8203;JohnTitor](https://togithub.com/JohnTitor)` in [https://github.com/rust-lang/libc/pull/3358](https://togithub.com/rust-lang/libc/pull/3358)
-   Add teeos libc by [`@&#8203;Sword-Destiny](https://togithub.com/Sword-Destiny)` in [https://github.com/rust-lang/libc/pull/3333](https://togithub.com/rust-lang/libc/pull/3333)
-   Added SIOCSIFNAME by [`@&#8203;Brijeshkrishna](https://togithub.com/Brijeshkrishna)` in [https://github.com/rust-lang/libc/pull/3354](https://togithub.com/rust-lang/libc/pull/3354)
-   copyfile apple api update by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3346](https://togithub.com/rust-lang/libc/pull/3346)
-   Hermit updates by [`@&#8203;mkroening](https://togithub.com/mkroening)` in [https://github.com/rust-lang/libc/pull/3348](https://togithub.com/rust-lang/libc/pull/3348)
-   Add the LoongArch64 HWCAP values by [`@&#8203;heiher](https://togithub.com/heiher)` in [https://github.com/rust-lang/libc/pull/3344](https://togithub.com/rust-lang/libc/pull/3344)
-   Add F_PUNCHHOLE and fpunchhole_t by [`@&#8203;anacrolix](https://togithub.com/anacrolix)` in [https://github.com/rust-lang/libc/pull/3337](https://togithub.com/rust-lang/libc/pull/3337)
-   Fix compatibility with Emscripten >= 3.1.44 by [`@&#8203;kleisauke](https://togithub.com/kleisauke)` in [https://github.com/rust-lang/libc/pull/3308](https://togithub.com/rust-lang/libc/pull/3308)
-   freebsd adding few mmap constants related to page alignment by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3326](https://togithub.com/rust-lang/libc/pull/3326)
-   Redox pthreads by [`@&#8203;4lDO2](https://togithub.com/4lDO2)` in [https://github.com/rust-lang/libc/pull/3347](https://togithub.com/rust-lang/libc/pull/3347)
-   linux MADV_COLLAPSE addition by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3340](https://togithub.com/rust-lang/libc/pull/3340)
-   android adding few more pthread api calls. by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3288](https://togithub.com/rust-lang/libc/pull/3288)
-   Declare `pthread_attr_setguardsize` and `pthread_attr_getstacksize`. by [`@&#8203;sunfishcode](https://togithub.com/sunfishcode)` in [https://github.com/rust-lang/libc/pull/3330](https://togithub.com/rust-lang/libc/pull/3330)
-   Add missing PS Vita definitions, fix some unused ones by [`@&#8203;pheki](https://togithub.com/pheki)` in [https://github.com/rust-lang/libc/pull/3284](https://togithub.com/rust-lang/libc/pull/3284)
-   Drop `armv7-apple-ios` target support by [`@&#8203;JohnTitor](https://togithub.com/JohnTitor)` in [https://github.com/rust-lang/libc/pull/3362](https://togithub.com/rust-lang/libc/pull/3362)
-   backtrace definitions and support for getmntinfo and getvfsstat by [`@&#8203;0323pin](https://togithub.com/0323pin)` in [https://github.com/rust-lang/libc/pull/3368](https://togithub.com/rust-lang/libc/pull/3368)
-   apple fcntl update. by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3365](https://togithub.com/rust-lang/libc/pull/3365)
-   Added socketpair and pipe2 for Vita target by [`@&#8203;nikarh](https://togithub.com/nikarh)` in [https://github.com/rust-lang/libc/pull/3366](https://togithub.com/rust-lang/libc/pull/3366)
-   Added additional Ethernet Protocol Ids for fuchsia by [`@&#8203;w1redch4d](https://togithub.com/w1redch4d)` in [https://github.com/rust-lang/libc/pull/3332](https://togithub.com/rust-lang/libc/pull/3332)
-   timerfd api for freebsd 14. by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3341](https://togithub.com/rust-lang/libc/pull/3341)
-   haiku adding pthread GNU part by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3364](https://togithub.com/rust-lang/libc/pull/3364)
-   add execveat for glibc by [`@&#8203;SteveLauC](https://togithub.com/SteveLauC)` in [https://github.com/rust-lang/libc/pull/3372](https://togithub.com/rust-lang/libc/pull/3372)
-   added support for GNU/Hurd by [`@&#8203;Vtewari2311](https://togithub.com/Vtewari2311)` in [https://github.com/rust-lang/libc/pull/3325](https://togithub.com/rust-lang/libc/pull/3325)
-   Fix apple tvos support by [`@&#8203;lcruz99](https://togithub.com/lcruz99)` in [https://github.com/rust-lang/libc/pull/3370](https://togithub.com/rust-lang/libc/pull/3370)
-   Remove deprecation from SA_ONSTACK; fix hexagon-unknown-linux-musl by [`@&#8203;androm3da](https://togithub.com/androm3da)` in [https://github.com/rust-lang/libc/pull/3335](https://togithub.com/rust-lang/libc/pull/3335)
-   feat: add close_range for glibc by [`@&#8203;SteveLauC](https://togithub.com/SteveLauC)` in [https://github.com/rust-lang/libc/pull/3373](https://togithub.com/rust-lang/libc/pull/3373)
-   Update crate version to 0.2.149 by [`@&#8203;nikarh](https://togithub.com/nikarh)` in [https://github.com/rust-lang/libc/pull/3360](https://togithub.com/rust-lang/libc/pull/3360)

#### New Contributors

-   [`@&#8203;Sword-Destiny](https://togithub.com/Sword-Destiny)` made their first contribution in [https://github.com/rust-lang/libc/pull/3333](https://togithub.com/rust-lang/libc/pull/3333)
-   [`@&#8203;Brijeshkrishna](https://togithub.com/Brijeshkrishna)` made their first contribution in [https://github.com/rust-lang/libc/pull/3354](https://togithub.com/rust-lang/libc/pull/3354)
-   [`@&#8203;anacrolix](https://togithub.com/anacrolix)` made their first contribution in [https://github.com/rust-lang/libc/pull/3337](https://togithub.com/rust-lang/libc/pull/3337)
-   [`@&#8203;4lDO2](https://togithub.com/4lDO2)` made their first contribution in [https://github.com/rust-lang/libc/pull/3347](https://togithub.com/rust-lang/libc/pull/3347)
-   [`@&#8203;pheki](https://togithub.com/pheki)` made their first contribution in [https://github.com/rust-lang/libc/pull/3284](https://togithub.com/rust-lang/libc/pull/3284)
-   [`@&#8203;0323pin](https://togithub.com/0323pin)` made their first contribution in [https://github.com/rust-lang/libc/pull/3368](https://togithub.com/rust-lang/libc/pull/3368)
-   [`@&#8203;w1redch4d](https://togithub.com/w1redch4d)` made their first contribution in [https://github.com/rust-lang/libc/pull/3332](https://togithub.com/rust-lang/libc/pull/3332)
-   [`@&#8203;Vtewari2311](https://togithub.com/Vtewari2311)` made their first contribution in [https://github.com/rust-lang/libc/pull/3325](https://togithub.com/rust-lang/libc/pull/3325)
-   [`@&#8203;lcruz99](https://togithub.com/lcruz99)` made their first contribution in [https://github.com/rust-lang/libc/pull/3370](https://togithub.com/rust-lang/libc/pull/3370)

**Full Changelog**: rust-lang/libc@0.2.148...0.2.149

</details>

<details>
<summary>serde-rs/serde (serde)</summary>

### [`v1.0.190`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.190)

[Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.189...v1.0.190)

-   Preserve NaN sign when deserializing f32 from f64 or vice versa ([#&#8203;2637](https://togithub.com/serde-rs/serde/issues/2637))

### [`v1.0.189`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.189)

[Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.188...v1.0.189)

-   Fix "cannot infer type" error when internally tagged enum contains untagged variant ([#&#8203;2613](https://togithub.com/serde-rs/serde/issues/2613), thanks [`@&#8203;ahl](https://togithub.com/ahl))`

</details>

<details>
<summary>serde-rs/json (serde_json)</summary>

### [`v1.0.108`](https://togithub.com/serde-rs/json/releases/tag/v1.0.108)

[Compare Source](https://togithub.com/serde-rs/json/compare/v1.0.107...v1.0.108)

-   Documentation improvements ([#&#8203;1075](https://togithub.com/serde-rs/json/issues/1075), [#&#8203;1081](https://togithub.com/serde-rs/json/issues/1081), [#&#8203;1082](https://togithub.com/serde-rs/json/issues/1082), thanks [`@&#8203;dimo414](https://togithub.com/dimo414)` and [`@&#8203;fritzrehde](https://togithub.com/fritzrehde))`

</details>

<details>
<summary>assert-rs/trycmd (snapbox)</summary>

### [`v0.4.14`](https://togithub.com/assert-rs/trycmd/compare/snapbox-v0.4.13...snapbox-v0.4.14)

[Compare Source](https://togithub.com/assert-rs/trycmd/compare/snapbox-v0.4.13...snapbox-v0.4.14)

</details>

<details>
<summary>dtolnay/syn (syn)</summary>

### [`v2.0.38`](https://togithub.com/dtolnay/syn/releases/tag/2.0.38)

[Compare Source](https://togithub.com/dtolnay/syn/compare/2.0.37...2.0.38)

-   Fix *"method 'peek' has an incompatible type for trait"* error when defining `bool` as a custom keyword ([#&#8203;1518](https://togithub.com/dtolnay/syn/issues/1518), thanks [`@&#8203;Vanille-N](https://togithub.com/Vanille-N))`

</details>

<details>
<summary>Stebalien/tempfile (tempfile)</summary>

### [`v3.8.1`](https://togithub.com/Stebalien/tempfile/blob/HEAD/CHANGELOG.md#381)

-   Update rustix to fix a potential panic on `persist_noclobber` on android.
-   Update redox_syscall to 0.4 (on redox).
-   Fix some docs typos.

</details>

<details>
<summary>dtolnay/thiserror (thiserror)</summary>

### [`v1.0.50`](https://togithub.com/dtolnay/thiserror/releases/tag/1.0.50)

[Compare Source](https://togithub.com/dtolnay/thiserror/compare/1.0.49...1.0.50)

-   Improve diagnostic when a #\[source], #\[from], or #\[transparant] attribute refers to a type that has no std::error::Error impl ([#&#8203;258](https://togithub.com/dtolnay/thiserror/issues/258), thanks [`@&#8203;de-vri-es](https://togithub.com/de-vri-es))`

</details>

<details>
<summary>toml-rs/toml (toml)</summary>

### [`v0.8.6`](https://togithub.com/toml-rs/toml/compare/toml-v0.8.5...toml-v0.8.6)

[Compare Source](https://togithub.com/toml-rs/toml/compare/toml-v0.8.5...toml-v0.8.6)

### [`v0.8.5`](https://togithub.com/toml-rs/toml/compare/toml-v0.8.4...toml-v0.8.5)

[Compare Source](https://togithub.com/toml-rs/toml/compare/toml-v0.8.4...toml-v0.8.5)

### [`v0.8.4`](https://togithub.com/toml-rs/toml/compare/toml-v0.8.3...toml-v0.8.4)

[Compare Source](https://togithub.com/toml-rs/toml/compare/toml-v0.8.3...toml-v0.8.4)

### [`v0.8.3`](https://togithub.com/toml-rs/toml/compare/toml-v0.8.2...toml-v0.8.3)

[Compare Source](https://togithub.com/toml-rs/toml/compare/toml-v0.8.2...toml-v0.8.3)

</details>

<details>
<summary>tokio-rs/tracing (tracing)</summary>

### [`v0.1.40`](https://togithub.com/tokio-rs/tracing/releases/tag/tracing-0.1.40): tracing 0.1.40

[Compare Source](https://togithub.com/tokio-rs/tracing/compare/tracing-0.1.39...tracing-0.1.40)

This release fixes a potential stack use-after-free in the
`Instrument::into_inner` method. Only uses of this method are affected by this
bug.

##### Fixed

-   Use `mem::ManuallyDrop` instead of `mem::forget` in `Instrument::into_inner`
    ([#&#8203;2765])

[#&#8203;2765]: https://togithub.com/tokio-rs/tracing/pull/2765

Thanks to [`@&#8203;cramertj](https://togithub.com/cramertj)` and [`@&#8203;manishearth](https://togithub.com/manishearth)` for finding and fixing this issue!

### [`v0.1.39`](https://togithub.com/tokio-rs/tracing/releases/tag/tracing-0.1.39): tracing 0.1.39

[Compare Source](https://togithub.com/tokio-rs/tracing/compare/tracing-0.1.38...tracing-0.1.39)

This release adds several additional features to the `tracing` macros. In
addition, it updates the `tracing-core` dependency to [v0.1.32][core-0.1.32] and
the `tracing-attributes` dependency to [v0.1.27][attrs-0.1.27].

##### Added

-   Allow constant field names in macros ([#&#8203;2617])
-   Allow setting event names in macros ([#&#8203;2699])
-   **core**: Allow `ValueSet`s of any length ([#&#8203;2508])

##### Changed

-   `tracing-attributes`: updated to [0.1.27][attrs-0.1.27]
-   `tracing-core`: updated to [0.1.32][core-0.1.32]
-   **attributes**: Bump minimum version of proc-macro2 to 1.0.60 ([#&#8203;2732])
-   **attributes**: Generate less dead code for async block return type hint ([#&#8203;2709])

##### Fixed

-   Use fully qualified names in macros for items exported from std prelude
    ([#&#8203;2621], [#&#8203;2757])
-   **attributes**: Allow \[`clippy::let_with_type_underscore`] in macro-generated
    code (\[[#&#8203;2609](https://togithub.com/tokio-rs/tracing/issues/2609)])
-   **attributes**: Allow `unknown_lints` in macro-generated code ([#&#8203;2626])
-   **attributes**: Fix a compilation error in `#[instrument]` when the `"log"`
    feature is enabled ([#&#8203;2599])

##### Documented

-   Add `axum-insights` to relevant crates. ([#&#8203;2713])
-   Fix link to RAI pattern crate documentation (\[[#&#8203;2612](https://togithub.com/tokio-rs/tracing/issues/2612)])
-   Fix docs typos and warnings ([#&#8203;2581])
-   Add `clippy-tracing` to related crates ([#&#8203;2628])
-   Add `tracing-cloudwatch` to related crates ([#&#8203;2667])
-   Fix deadlink to `tracing-etw` repo ([#&#8203;2602])

[#&#8203;2617]: https://togithub.com/tokio-rs/tracing/pull/2617

[#&#8203;2699]: https://togithub.com/tokio-rs/tracing/pull/2699

[#&#8203;2508]: https://togithub.com/tokio-rs/tracing/pull/2508

[#&#8203;2621]: https://togithub.com/tokio-rs/tracing/pull/2621

[#&#8203;2713]: https://togithub.com/tokio-rs/tracing/pull/2713

[#&#8203;2581]: https://togithub.com/tokio-rs/tracing/pull/2581

[#&#8203;2628]: https://togithub.com/tokio-rs/tracing/pull/2628

[#&#8203;2667]: https://togithub.com/tokio-rs/tracing/pull/2667

[#&#8203;2602]: https://togithub.com/tokio-rs/tracing/pull/2602

[#&#8203;2626]: https://togithub.com/tokio-rs/tracing/pull/2626

[#&#8203;2757]: https://togithub.com/tokio-rs/tracing/pull/2757

[#&#8203;2732]: https://togithub.com/tokio-rs/tracing/pull/2732

[#&#8203;2709]: https://togithub.com/tokio-rs/tracing/pull/2709

[#&#8203;2599]: https://togithub.com/tokio-rs/tracing/pull/2599

[`let_with_type_underscore`]: http://rust-lang.github.io/rust-clippy/rust-1.70.0/index.html#let_with_type_underscore

[attrs-0.1.27]: https://togithub.com/tokio-rs/tracing/releases/tag/tracing-attributes-0.1.27

[core-0.1.32]: https://togithub.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.32

### [`v0.1.38`](https://togithub.com/tokio-rs/tracing/releases/tag/tracing-0.1.38): tracing 0.1.38

[Compare Source](https://togithub.com/tokio-rs/tracing/compare/tracing-0.1.37...tracing-0.1.38)

This `tracing` release changes the `Drop` implementation for `Instrumented`
`Future`s so that the attached `Span` is entered when dropping the `Future`. This
means that events emitted by the `Future`'s `Drop` implementation will now be
recorded within its `Span`. It also adds `#[inline]` hints to methods called in
the `event!` macro's expansion, for an improvement in both binary size and
performance.

Additionally, this release updates the `tracing-attributes` dependency to
[v0.1.24][attrs-0.1.24], which updates the [`syn`][syn] dependency to v2.x.x.
`tracing-attributes` v0.1.24 also includes improvements to the `#[instrument]`
macro; see [the `tracing-attributes` 0.1.24 release notes][attrs-0.1.24] for
details.

##### Added

-   `Instrumented` futures will now enter the attached `Span` in their `Drop`
    implementation, allowing events emitted when dropping the future to occur
    within the span ([#&#8203;2562](https://togithub.com/tokio-rs/tracing/issues/2562))
-   `#[inline]` attributes for methods called by the `event!` macros, making
    generated code smaller ([#&#8203;2555](https://togithub.com/tokio-rs/tracing/issues/2555))
-   **attributes**: `level` argument to `#[instrument(err)]` and
    `#[instrument(ret)]` to override the level of
    the generated return value event ([#&#8203;2335](https://togithub.com/tokio-rs/tracing/issues/2335))
-   **attributes**: Improved compiler error message when `#[instrument]` is added to a `const fn`
    ([#&#8203;2418](https://togithub.com/tokio-rs/tracing/issues/2418))

##### Changed

-   `tracing-attributes`: updated to [0.1.24][attrs-0.1.24]
-   Removed unneeded `cfg-if` dependency ([#&#8203;2553](https://togithub.com/tokio-rs/tracing/issues/2553))
-   **attributes**: Updated [`syn`][syn] dependency to 2.0 ([#&#8203;2516](https://togithub.com/tokio-rs/tracing/issues/2516))

##### Fixed

-   **attributes**: Fix `clippy::unreachable` warnings in `#[instrument]`-generated code ([#&#8203;2356](https://togithub.com/tokio-rs/tracing/issues/2356))
-   **attributes**: Removed unused "visit" feature flag from `syn` dependency ([#&#8203;2530](https://togithub.com/tokio-rs/tracing/issues/2530))

##### Documented

-   **attributes**: Documented default level for `#[instrument(err)]` ([#&#8203;2433](https://togithub.com/tokio-rs/tracing/issues/2433))
-   **attributes**: Improved documentation for levels in `#[instrument]` ([#&#8203;2350](https://togithub.com/tokio-rs/tracing/issues/2350))

Thanks to [`@&#8203;nitnelave](https://togithub.com/nitnelave),` [`@&#8203;jsgf](https://togithub.com/jsgf),` [`@&#8203;Abhicodes-crypto](https://togithub.com/Abhicodes-crypto),` [`@&#8203;LukeMathWalker](https://togithub.com/LukeMathWalker),` [`@&#8203;andrewpollack](https://togithub.com/andrewpollack),`
[`@&#8203;quad](https://togithub.com/quad),` [`@&#8203;klensy](https://togithub.com/klensy),` [`@&#8203;davidpdrsn](https://togithub.com/davidpdrsn),` [`@&#8203;dbidwell94](https://togithub.com/dbidwell94),` [`@&#8203;ldm0](https://togithub.com/ldm0),` [`@&#8203;NobodyXu](https://togithub.com/NobodyXu),` [`@&#8203;ilsv](https://togithub.com/ilsv),` and [`@&#8203;daxpedda](https://togithub.com/daxpedda)`
for contributing to this release!

[`syn`]: https://crates.io/crates/syn

[attrs-0.1.24]: https://togithub.com/tokio-rs/tracing/releases/tag/tracing-attributes-0.1.24

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rust-lang/cargo).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet