feat: impl From<Flush> to MZFlush #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosminPerRam
changed the title
|
I also reordered |
|
Also found a spelling mistake and a missing |
Byron
reviewed
Feb 18, 2025
src/mem.rs
Outdated
| /// | ||
| /// All input data so far will be available to the decompressor (as with | ||
| /// `Flush::Sync`). This completes the current deflate block and follows it | ||
| /// with an empty fixed codes block that is 10 bites long, and it assures |
There was a problem hiding this comment.
Suggested change
| /// with an empty fixed codes block that is 10 bites long, and it assures | |
| /// with an empty fixed codes block that is 10 bytes long, and it assures |
There was a problem hiding this comment.
I am aware this typos wasn't introduced here, but we might as well fix it now.
There was a problem hiding this comment.
Thanks a lot for your continued contributions, they are much appreciated!
Thank you for the kind words, I'm just doing what I can in my capabilities (:
Byron
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would never hit an error in building a
MZFlush, because all values of FlushDecompress and FlushCompress (asi32) map to MZFlush.Implementing
Fromto it is simpler and better as we get rid of the redundant.unwrap()s, casts toi32and can see directly the translation.For more context for the mapping done here, see MZFlush::new.