Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build crates with minimal versions in CI #1190

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Build crates with minimal versions in CI #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1949748
Build crates with minimal versions in CI
MajorBreakfast Aug 10, 2018
a105d7c
Use --manifest-path instead of -p
MajorBreakfast Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ matrix:
- name: cargo test
os: linux

- name: cargo test (with minimal versions)
os: linux
script:
- cargo update -Zminimal-versions
- cargo test

- name: cargo clippy
rust: nightly
install:
Expand All @@ -23,7 +29,7 @@ matrix:
rust: nightly
script:
- cargo bench --all
- cargo bench -p futures-util-preview --features=bench
- cargo bench --manifest-path futures-util/Cargo.toml --features=bench

- name: cargo build --no-default-features
rust: nightly
Expand All @@ -47,6 +53,18 @@ matrix:
- cargo build --manifest-path futures-sink/Cargo.toml --all-features
- cargo build --manifest-path futures-util/Cargo.toml --all-features

- name: cargo build --all-features (with minimal versions)
rust: nightly
script:
- cargo update -Zminimal-versions
- cargo build --manifest-path futures/Cargo.toml --all-features
- cargo build --manifest-path futures-core/Cargo.toml --all-features
- cargo build --manifest-path futures-channel/Cargo.toml --all-features
- cargo build --manifest-path futures-executor/Cargo.toml --all-features
- cargo build --manifest-path futures-io/Cargo.toml --all-features
- cargo build --manifest-path futures-sink/Cargo.toml --all-features
- cargo build --manifest-path futures-util/Cargo.toml --all-features
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use cargo build --all-features or cargo build -p futures-... --all-features instead?

cargo build --no-default-features seems not to exist at least

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo build --all-features might also not work. It exists but I'm not sure whether it does what we want

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, features and workspaces are pretty much broken at the moment. There was an attempt at fixing them a while ago, but I’m not sure if that’s still available even as an unstable flag. I’ll try and find the link to the issue in a sec.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/cargo#5364

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested -p instead of --manifest-path and it doesn't work


- name: cargo build --target=thumbv6m-none-eabi
rust: nightly
install:
Expand Down
2 changes: 1 addition & 1 deletion futures-executor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ default = ["std"]
futures-core-preview = { path = "../futures-core", version = "0.3.0-alpha.2", default-features = false}
futures-util-preview = { path = "../futures-util", version = "0.3.0-alpha.2", default-features = false}
futures-channel-preview = { path = "../futures-channel", version = "0.3.0-alpha.2", default-features = false}
num_cpus = { version = "1.0", optional = true }
num_cpus = { version = "1.8.0", optional = true }
lazy_static = { version = "1.1.0", optional = true }
pin-utils = "0.1.0-alpha.1"

Expand Down