Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race with dropping mpsc::Receiver #1241

Merged
merged 3 commits into from
Sep 2, 2018
Merged

fix race with dropping mpsc::Receiver #1241

merged 3 commits into from
Sep 2, 2018

Conversation

carllerche
Copy link
Member

Fix a bug where messages sent into a channel at the same time as the
Receiver is dropped are never removed.

The impl in 0.3 suffers the same bug.

Fixes #909

@carllerche
fix race with dropping mpsc::Receiver
99416a6 
Fix a bug where messages sent into a channel at the same time as the
`Receiver` is dropped are never removed.

Fixes rust-lang#909
@carllerche
Get tests passing on 1.15
0a0b2d5
@carllerche
Try to fix for 1.15 again
7b38d8f
@carllerche carllerche mentioned this pull request Sep 1, 2018
Closed
2 tasks
@MajorBreakfast
Copy link
Contributor

This needs review by either @aturon or @cramertj because I'm not familiar with that part of the code base. I do however think that it's important that this gets merged

@MajorBreakfast MajorBreakfast mentioned this pull request Sep 2, 2018
Closed
seanmonstar
seanmonstar approved these changes Sep 2, 2018
View reviewed changes
Copy link
Contributor

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously reviewed this for tokio, and this is a backport, so r+.

@MajorBreakfast MajorBreakfast merged commit 12ca605 into rust-lang:0.1 Sep 2, 2018
@carllerche carllerche mentioned this pull request Sep 11, 2018
Closed
@taiki-e taiki-e mentioned this pull request Jan 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

@cramertj cramertj Awaiting requested review from cramertj

@aturon aturon Awaiting requested review from aturon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carllerche @MajorBreakfast @seanmonstar