Add AsyncBufRead trait #1552
Merged
Add AsyncBufRead trait #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemo157
reviewed
Apr 25, 2019
taiki-e
force-pushed
the
io-async-buf-read
branch
from
52fd329 to
1fb2e15
Compare
Nemo157
approved these changes
Apr 25, 2019
cramertj
reviewed
Apr 25, 2019
| @@ -324,3 +322,61 @@ pub trait AsyncWriteExt: AsyncWrite { | |||
| } | |||
|
|
|||
| impl<W: AsyncWrite + ?Sized> AsyncWriteExt for W {} | |||
|
|
|||
| /// An extension trait which adds utility methods to `AsyncBufRead` types. | |||
| pub trait AsyncBufReadExt: AsyncBufRead { | |||
There was a problem hiding this comment.
I imagine we'll also want read_line, lines etc. but those can wait for a followup
cramertj
reviewed
Apr 25, 2019
cramertj
reviewed
Apr 25, 2019
taiki-e
force-pushed
the
io-async-buf-read
branch
from
1fb2e15 to
0058ab4
Compare
taiki-e
commented
Apr 25, 2019
taiki-e
force-pushed
the
io-async-buf-read
branch
from
0058ab4 to
bca5017
Compare
taiki-e
commented
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
AsyncBufReadtrait andAsyncBufRead::read_untilmethod.(I'm writing async
BufWriternow, butI want to add some methods and trait implementations that requireI would like to add traits ahead.)AsyncSeek, socc #1519