Add async BufReader #1573
Add async BufReader #1573
Conversation
| use std::{cmp, fmt}; | ||
| use super::DEFAULT_BUF_SIZE; | ||
|
|
||
| /// The `BufReader` struct adds buffering to any reader. |
There was a problem hiding this comment.
BufReader vs AsyncBufReader
(I have no strong opinion.)
There was a problem hiding this comment.
Given it's a concrete type, and not a trait, I think BufReader is fine. It's similar to the naming scheme in Romio, Tokio, and Runtime 👍
There was a problem hiding this comment.
I wonder if AsyncRead and AsyncWrite should've been named PollRead and PollWrite (because they only have polling read/write methods).
Then we could rename AsyncReadExt and AsyncWriteExt to simply Read and Write.
I don't see much point in the Async prefix if literally no other trait or type has it. Also, the Async* traits with polling methods are not indented to be used by end-users so it feels wrong for them to have simpler names than the *Ext traits which are used more often.
There was a problem hiding this comment.
@stjepang that's an interesting point; perhaps opening a separate issue might be good for a discussion?
There was a problem hiding this comment.
@stjepang the Async* traits are what should be used in bounds so likely used multiple times per file, whereas the *Ext traits should be imported and then be used via method syntax so only mentioned once per file.
taiki-e
force-pushed
the
io-buf_reader
branch
2 times, most recently
from
b69b486
to
1278df1
Compare
cc #1519