Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::error::Error for SpawnError #1604

Merged
merged 2 commits into from
May 15, 2019
Merged

Implement std::error::Error for SpawnError #1604

merged 2 commits into from
May 15, 2019

Conversation

jrobsonchase
Copy link
Contributor

Pretty straightforward - just a Display and Error implementation for SpawnError.

taiki-e
taiki-e reviewed May 14, 2019
View reviewed changes
futures-core/src/task/spawn.rs
}
}

impl std::error::Error for SpawnError {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add #[cfg(feature = "std")] to this impl.

@cramertj cramertj merged commit 7182347 into rust-lang:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrobsonchase @taiki-e @cramertj