Add future::try_select #1622
Merged
Add future::try_select #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any situation you would prefer this over |
taiki-e
force-pushed
the
future-try_select
branch
from
46aea70
to
649c0e2
Compare
|
|
taiki-e
force-pushed
the
future-try_select
branch
from
649c0e2
to
fa63a54
Compare
cramertj
reviewed
May 20, 2019
| impl<A: Unpin, B: Unpin> Future for TrySelect<A, B> | ||
| where A: TryFuture, B: TryFuture | ||
| { | ||
| #[allow(clippy::type_complexity)] |
|
seems basically fine to me, and could help people move over code directly without going all the way to async/await. It is unfortunate to have all of these "multiple ways to do things" but after all that's sort of why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as 0.1's select2.