Make all extension traits unnamed in the prelude #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened rust-lang/rust#61592 to try and have nicer docs eventually. |
|
CI fail is because a new minor version of rand_core has been released. I am writing a fix for this now. |
|
Opened #1664 for fixing CI fail. |
Nemo157
force-pushed
the
unnamed-extensions
branch
from
c5564ed
to
5dc5eae
Compare
yoshuawuyts
approved these changes
Jun 6, 2019
|
Updated to use
|
taiki-e
approved these changes
Jun 7, 2019
|
NIce, that's a good trick! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for avoiding accidental shadowing of glob imported preludes, the methods will be brought into scope but the trait itself will have no name so can't be shadowed by things like
use futures_timer::FutureExt;.Unfortunately
rustdocdoesn't render these well, but hopefully that can get fixed at some point