Add io::Window::set #1667
Merged
Add io::Window::set #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
reviewed
Jun 11, 2019
futures-util/src/io/window.rs
Outdated
| @@ -65,43 +65,36 @@ impl<T: AsRef<[u8]>> Window<T> { | |||
| self.range.end | |||
| } | |||
|
|
|||
| /// Changes the starting index of this window to the index specified. | |||
| /// Changes the range of this window to the range specified. | |||
| /// | |||
| /// Returns the windows back to chain multiple calls to this method. | |||
There was a problem hiding this comment.
not new to this change, but why would you want to chain multiple calls to this method?
There was a problem hiding this comment.
That's certainly not necessary because we can now set the range at once with set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And removed
set_startandset_end.