Add ThreadPool::spawn_ok and spawn_obj_ok #1750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering that
spawn
andspawn_obj
never fail on theThreadPool
, it is desirable to add alternative methods that indeed cannot fail to spawn tasks.I added this
_ok
suffix, otherwise that would be a breaking change. People's code would suddenly use the inherent method instead of the trait method, and likely get a compilation error because you can't callunwrap()
on()
.Now that
SpawnError
unfortunately no longer contains theFuture
that failed to spawn, it is no longer possible to properly handle tasks spawn failures.