Fix SplitSink performance problem #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like both |
doyoubi
changed the title
doyoubi
changed the title
doyoubi
commented
Nov 13, 2019
| ready!(inner.as_pin_mut().poll_ready(cx))?; | ||
| inner.as_pin_mut().start_send(this.slot.take().unwrap())?; | ||
| } | ||
| ready!(Self::poll_flush_slot(inner.as_pin_mut(), &mut this.slot, cx))?; |
There was a problem hiding this comment.
Move the this.lock.poll_lock(cx) out of poll_flush_slot to avoid the need to poll_lock again to get the inner.
There was a problem hiding this comment.
Ah, yeah, I missed that it needs the lock across both operations.
|
Please take a look. Thanks |
Nemo157
approved these changes
Nov 13, 2019
| ready!(inner.as_pin_mut().poll_ready(cx))?; | ||
| inner.as_pin_mut().start_send(this.slot.take().unwrap())?; | ||
| } | ||
| ready!(Self::poll_flush_slot(inner.as_pin_mut(), &mut this.slot, cx))?; |
There was a problem hiding this comment.
Ah, yeah, I missed that it needs the lock across both operations.
|
Oh, I just merge master to this branch to update it. Shall I revert it and use rebase instead? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the related issue for details.
Maybe I should add tests for this "buffering guarantee"?