Use first nonempty buffer in vectored I/O #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation would use the first buffer even when it was empty and other nonempty buffers are provided. This could result in `Ok(0)` return value which has otherwise a special meaning. The new implementation uses the first nonempty buffer instead to avoid the issue. Previous implementation would return early if no buffers are provided. The new implementation delegates operation using an empty buffer. This gives an implementation an ability to decide how an empty read / write operation should behave. This change aligns the implementation with synchronous version of those traits.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation would use the first buffer even when it was
empty and other nonempty buffers are provided. This could result in
Ok(0)return value which has otherwise a special meaning. The newimplementation uses the first nonempty buffer instead to avoid the
issue.
Previous implementation would return early if no buffers are provided.
The new implementation delegates operation using an empty buffer. This
gives an implementation an ability to decide how an empty read / write
operation should behave.
This change aligns the implementation with synchronous version of those
traits.