Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AtomicWaker::new() a const fn #2007

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Make AtomicWaker::new() a const fn #2007

merged 1 commit into from
Dec 18, 2019

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Dec 16, 2019 •
edited
Loading

Allows doing static FOO: AtomicWaker = AtomicWaker::new();.

yoshuawuyts
yoshuawuyts approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is very cool!

@Nemo157
Copy link
Member

Nemo157 commented Dec 16, 2019

CI failure is the ! stabilization revert I mentioned in #2000 (comment), I can hopefully open another PR refixing CI soon.

@cramertj cramertj merged commit 3c09c69 into rust-lang:master Dec 18, 2019
@tomaka tomaka deleted the const-new-atomic-waker branch December 18, 2019 09:13
@tomaka tomaka restored the const-new-atomic-waker branch December 18, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomaka @Nemo157 @yoshuawuyts @cramertj