Add impl Spawn and LocalSpawn for Arc and Rc. #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if something like this would make sense for |
|
This seems to fail on |
Could you use |
najamelan
force-pushed
the
feature/impl_spawn_for_arc
branch
from
b8bbfe4
to
1629373
Compare
Since rust-lang#1950 (0.3.0) the Spawn and LocalSpawn only require a shared reference for spawning operations. This adds blanket impls for `Arc<Sp: ?Sized + Spawn>` and `Rc<Sp: ?Sized + Spawn>`. It does the same for LocalSpawn. This allows client code to pass an Arc<Exec> when library code takes parameters as `&dyn Spawn` or `impl Spawn`. So far there were blanket impls for `&`, `&mut` and `Box`.
najamelan
force-pushed
the
feature/impl_spawn_for_arc
branch
from
1629373
to
94fff6b
Compare
|
Limited Arc impl under |
|
Thanks! |
|
Awesome. Any idea when a version 0.3.2 might be released? Seems quite some work has happened since November. |
|
I'll release one next week, thanks for asking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1950 (0.3.0) the Spawn and LocalSpawn only require a shared reference
for spawning operations.
This adds blanket impls for
Arc<Sp: ?Sized + Spawn>andRc<Sp: ?Sized + Spawn>.It does the same for LocalSpawn.
This allows client code to pass an Arc when library code takes
parameters as
&dyn Spawnorimpl Spawn.So far there were blanket impls for
&,&mutandBox.