Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test utility that verifies an AsyncWrite is closed correctly #2159

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Add test utility that verifies an AsyncWrite is closed correctly #2159

merged 3 commits into from
Sep 5, 2020

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented May 15, 2020

No description provided.

@Nemo157
Copy link
Member Author

Nemo157 commented May 15, 2020

I used a slightly simplified version of this utility in Nullus157/async-compression#92 to regression test a silly mistake.

taiki-e
taiki-e reviewed May 16, 2020
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- maybe should Sink have similar test utility?

@Nemo157
Copy link
Member Author

Nemo157 commented May 16, 2020

Yep, makes sense to have it working for sink too

@taiki-e taiki-e merged commit ea43500 into rust-lang:master Sep 5, 2020
@taiki-e taiki-e mentioned this pull request Oct 5, 2020
Merged
@taiki-e taiki-e added futures-test A-sink Area: futures::sink A-io Area: futures::io labels Jan 11, 2021
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-io Area: futures::io A-sink Area: futures::sink futures-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @taiki-e