Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(futures-util/stream): unzip operator #2263

Merged
merged 4 commits into from
Nov 18, 2020
Merged

feat(futures-util/stream): unzip operator #2263

merged 4 commits into from
Nov 18, 2020

Conversation

binier
Copy link
Contributor

@binier binier commented Nov 14, 2020

Given that Iterator::unzip is like .collect::<(Vec<_>, Vec<_>)>, I would prefer to separate functionality like Shared Stream from Unzip.

Originally posted by @taiki-e in #2256 (comment)

This version does exactly that.

closes: #2234

@taiki-e taiki-e self-requested a review November 15, 2020 18:11
taiki-e
taiki-e reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

futures-util/src/stream/stream/unzip.rs Outdated Show resolved Hide resolved
binier and others added 2 commits November 16, 2020 08:44
@binier @taiki-e
refactor(futures-util/stream): replace mem::take with `mem::replace…
24e4a5f 
…` to support older Rust version

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@binier
Merge branch 'master' into feat/stream-unzip
66aa57a
@taiki-e taiki-e merged commit 98e4dfc into rust-lang:master Nov 18, 2020
@taiki-e taiki-e added the A-stream Area: futures::stream label Jan 6, 2021
@taiki-e taiki-e mentioned this pull request Jan 8, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
exrook pushed a commit to exrook/futures-rs that referenced this pull request Apr 5, 2021
@binier
feat(futures-util/stream): add StreamExt::unzip (rust-lang#2263)
3e306c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-stream Area: futures::stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing StreamExt::unzip
2 participants
@binier @taiki-e